On Wed, Feb 22, 2017 at 4:29 PM, Steven Whitehouse <swhit...@redhat.com> wrote: > There should be no need to retry at all. Either the new entry will be added > to the hash table, or it will find an existing entry in the table. Is there > really some way this can fail for some reason?
Yes, we may find an existing entry but by the time we try to get a lockref, the entry may be dead. In that case, the right thing to do is to retry the insert. Andreas