On Fri, Jul 28, 2017 at 2:37 PM, Bob Peterson <[email protected]> wrote: > Hi, > > This patch moves the call to gfs2_delete_debugfs_file so that it > comes after the glock hash table has been cleared. This way we > can query the debugfs files if umount hangs. > > Signed-off-by: Bob Peterson <[email protected]> > --- > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c > index e76058d34b74..51752de54f11 100644 > --- a/fs/gfs2/ops_fstype.c > +++ b/fs/gfs2/ops_fstype.c > @@ -1388,7 +1388,6 @@ static void gfs2_kill_sb(struct super_block *sb) > sdp->sd_root_dir = NULL; > sdp->sd_master_dir = NULL; > shrink_dcache_sb(sb); > - gfs2_delete_debugfs_file(sdp); > free_percpu(sdp->sd_lkstats); > kill_block_super(sb); > } > diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c > index 87271a859a8d..1918bb5fc943 100644 > --- a/fs/gfs2/super.c > +++ b/fs/gfs2/super.c > @@ -924,6 +924,7 @@ static void gfs2_put_super(struct super_block *sb) > gfs2_jindex_free(sdp); > /* Take apart glock structures and buffer lists */ > gfs2_gl_hash_clear(sdp); > + gfs2_delete_debugfs_file(sdp); > /* Unmount the locking protocol */ > gfs2_lm_unmount(sdp);
This looks useful and correct. Thanks, Andreas
