On Wed, Oct 17, 2018 at 4:43 AM Christoph Hellwig <[email protected]> wrote:
> > +/**
> > + * gfs2_end_log_read - end I/O callback for reads from the log
> > + * @bio: The bio
> > + *
> > + * Simply unlock the pages in the bio. The main thread will wait on
> them and
> > + * process them in order as necessary.
> > + */
> > +
> > +static void gfs2_end_log_read(struct bio *bio)
> > +{
> > + struct gfs2_sbd *sdp = bio->bi_private;
> > + struct page *page;
> > + struct bio_vec *bvec;
> > + int i;
> > +
> > + if (bio->bi_status)
> > + fs_err(sdp, "Error %d reading from journal\n",
> bio->bi_status);
>
> How is error handling forthis going to work?
>
It's not. I'll post an updated version.
>
> > + bio_set_op_attrs(bio, REQ_OP_READ, 0);
>
> Please assign to bi_opf directly instead of using bio_set_op_attrs.
>
Yes. Didn't realize this was deprecated. There's another place where this
is used. The updated patch will address this.
Thanks for the review!
Cheers!
--Abhi
