On Mon, Apr 29, 2019 at 07:46:29PM +0200, Andreas Gruenbacher wrote: > On Mon, 29 Apr 2019 at 18:32, Andreas Gruenbacher <agrue...@redhat.com> wrote: > > From: Christoph Hellwig <h...@lst.de> > > > > Move the call to __generic_write_end into iomap_write_end instead of > > duplicating it in each of the three branches. This requires open coding > > the generic_write_end for the buffer_head case. > > Wouldn't it make sense to turn __generic_write_end into a void > function? Right now, it just oddly return its copied argument.
Yes, we could remove the return value. That should be a separate patch after this one, though.
