On Wed, Jul 22, 2020 at 08:18:50AM +0200, Christoph Hellwig wrote: > On Tue, Jul 21, 2020 at 01:37:49PM -0700, Darrick J. Wong wrote: > > On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote: > > > Failing to invalid the page cache means data in incoherent, which is > > > a very bad state for the system. Always fall back to buffered I/O > > > through the page cache if we can't invalidate mappings. > > > > > > Signed-off-by: Christoph Hellwig <h...@lst.de> > > > Acked-by: Dave Chinner <dchin...@redhat.com> > > > Reviewed-by: Goldwyn Rodrigues <rgold...@suse.com> > > > > For the iomap and xfs parts, > > Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > > > > But I'd still like acks from Ted, Andreas, and Damien for ext4, gfs2, > > and zonefs, respectively. > > > > (Particularly if anyone was harboring ideas about trying to get this in > > before 5.10, though I've not yet heard anyone say that explicitly...) > > Why would we want to wait another whole merge window?
Well it /is/ past -rc6, which is a tad late... OTOH we've been talking about this for 2 months now and most of the actual behavior change is in xfs land so maybe it's fine. :) --D
