[Cluster-devel] [PATCH] GFS2: move sleep outside the spinlock

[cgel . zte]

From: Lv Ruyi <lv.r...@zte.com.cn>

Don't sleep with spinlock held, so move it outside critical section.

Reported-by: Zeal Robot <zea...@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.r...@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel....@gmail.com>
---
 fs/gfs2/lock_dlm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c
index 50578f881e6d..e43b33b115b4 100644
--- a/fs/gfs2/lock_dlm.c
+++ b/fs/gfs2/lock_dlm.c
@@ -942,14 +942,15 @@ static int control_mount(struct gfs2_sbd *sdp)
                if (sdp->sd_args.ar_spectator) {
                        fs_info(sdp, "Recovery is required. Waiting for a "
                                "non-spectator to mount.\n");
+                       spin_unlock(&ls->ls_recover_spin);
                        msleep_interruptible(1000);
                } else {
                        fs_info(sdp, "control_mount wait1 block %u start %u "
                                "mount %u lvb %u flags %lx\n", block_gen,
                                start_gen, mount_gen, lvb_gen,
                                ls->ls_recover_flags);
+                       spin_unlock(&ls->ls_recover_spin);
                }
-               spin_unlock(&ls->ls_recover_spin);
                goto restart;
        }
 
-- 
2.25.1