On Wed, 30 Mar 2022 11:56:41 +0800 Christoph Hellwig wrote: >> As the potential failure of mempool_alloc(), >> it could return NULL pointer. >> Therefore, it should be better to check it >> in order to avoid the dereference of the NULL >> pointer. >> >> Fixes: e8c92ed76900 ("GFS2: Clean up log write code path") >> Signed-off-by: Jiasheng Jiang <jiash...@iscas.ac.cn> > > Please explain how it could fail to start with.
I think that for safety, the cost of redundant and harmless check is acceptable. Also, checking after allocation is a good program pattern. Therefore, it should be better to check it although it is hard to fail. Thanks, Jiang