Re: [Cluster-devel] [f2fs-dev] [PATCH v3 12/23] f2fs: Convert f2fs_flush_inline_data() to use filemap_get_folios_tag()

[Chao Yu]

On 2022/10/18 4:24, Vishal Moola (Oracle) wrote:

Convert function to use a folio_batch instead of pagevec. This is in
preparation for the removal of find_get_pages_tag().

Signed-off-by: Vishal Moola (Oracle) <vishal.mo...@gmail.com>

Acked-by: Chao Yu <c...@kernel.org>

Thanks,

---
  fs/f2fs/node.c | 17 +++++++++--------
  1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index e8b72336c096..a2f477cc48c7 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1887,17 +1887,18 @@ static bool flush_dirty_inode(struct page *page)
  void f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
  {
        pgoff_t index = 0;
-       struct pagevec pvec;
-       int nr_pages;
+       struct folio_batch fbatch;
+       int nr_folios;

- pagevec_init(&pvec);

+       folio_batch_init(&fbatch);

- while ((nr_pages = pagevec_lookup_tag(&pvec,

-                       NODE_MAPPING(sbi), &index, PAGECACHE_TAG_DIRTY))) {
+       while ((nr_folios = filemap_get_folios_tag(NODE_MAPPING(sbi), &index,
+                                       (pgoff_t)-1, PAGECACHE_TAG_DIRTY,
+                                       &fbatch))) {
                int i;

- for (i = 0; i < nr_pages; i++) {

-                       struct page *page = pvec.pages[i];
+               for (i = 0; i < nr_folios; i++) {
+                       struct page *page = &fbatch.folios[i]->page;

if (!IS_DNODE(page))

                                continue;
@@ -1924,7 +1925,7 @@ void f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
                        }
                        unlock_page(page);
                }
-               pagevec_release(&pvec);
+               folio_batch_release(&fbatch);
                cond_resched();
        }
  }