Re: [Cluster-devel] [RFC v3 5/7] iomap: Get page in page_prepare handler

[Matthew Wilcox]

On Fri, Dec 16, 2022 at 04:06:24PM +0100, Andreas Gruenbacher wrote:
> +     if (page_ops && page_ops->page_prepare)
> +             folio = page_ops->page_prepare(iter, pos, len);
> +     else
> +             folio = iomap_folio_prepare(iter, pos);
> +     if (IS_ERR_OR_NULL(folio)) {
> +             if (!folio)
> +                     return (iter->flags & IOMAP_NOWAIT) ? -EAGAIN : -ENOMEM;
> +             return PTR_ERR(folio);

Wouldn't it be cleaner if iomap_folio_prepare() always
returned an ERR_PTR on failure?