From: Johannes Thumshirn <johannes.thumsh...@wdc.com>

The md-raid superblock writing code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is never
checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Signed-of_-by: Johannes Thumshirn <johannes.thumsh...@wdc.com>
Reviewed-by: Damien Le Moal <damien.lem...@opensource.wdc.com>
Acked-by: Song Liu <s...@kernel.org>
---
 drivers/md/md.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 13321dbb5fbc..20b9cd7c2f39 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -958,7 +958,7 @@ void md_super_write(struct mddev *mddev, struct md_rdev 
*rdev,
        atomic_inc(&rdev->nr_pending);
 
        bio->bi_iter.bi_sector = sector;
-       bio_add_page(bio, page, size, 0);
+       __bio_add_page(bio, page, size, 0);
        bio->bi_private = rdev;
        bio->bi_end_io = super_written;
 
@@ -999,7 +999,7 @@ int sync_page_io(struct md_rdev *rdev, sector_t sector, int 
size,
                bio.bi_iter.bi_sector = sector + rdev->new_data_offset;
        else
                bio.bi_iter.bi_sector = sector + rdev->data_offset;
-       bio_add_page(&bio, page, size, 0);
+       __bio_add_page(&bio, page, size, 0);
 
        submit_bio_wait(&bio);
 
-- 
2.39.2

Reply via email to