This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".
The branch, next has been updated
via eb2ec05131f8e2a241c02c5fb3e7f03d1d6b54de (commit)
via 8d70a91489d74bd6056ba6858d815f5ee47a2e67 (commit)
from ed359fefbc80b68c3cdf91daa082cd74997f20e6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eb2ec05131f8e2a241c02c5fb3e7f03d1d6b54de
commit eb2ec05131f8e2a241c02c5fb3e7f03d1d6b54de
Merge: ed359fe 8d70a91
Author: Brad King <brad.k...@kitware.com>
AuthorDate: Tue Dec 23 08:27:30 2014 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Tue Dec 23 08:27:30 2014 -0500
Merge topic 'doc-octothorpe-escaping' into next
8d70a914 Help: Add 3.1 release note about '#' escaping in Makefiles (#15322)
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8d70a91489d74bd6056ba6858d815f5ee47a2e67
commit 8d70a91489d74bd6056ba6858d815f5ee47a2e67
Author: Brad King <brad.k...@kitware.com>
AuthorDate: Tue Dec 23 04:07:04 2014 -0500
Commit: Brad King <brad.k...@kitware.com>
CommitDate: Tue Dec 23 08:27:05 2014 -0500
Help: Add 3.1 release note about '#' escaping in Makefiles (#15322)
The change in commit v3.1.0-rc1~174^2 (Makefile: Handle '#' in
COMPILE_OPTIONS, 2014-08-12) was not compatible with code that
tries to workaround the original bug. Unfortunately there is no
good way to fix the bug in a compatible way. Add a release note
to call attention to the change.
diff --git a/Help/release/3.1.0.rst b/Help/release/3.1.0.rst
index a5b3e8e..97a63f9 100644
--- a/Help/release/3.1.0.rst
+++ b/Help/release/3.1.0.rst
@@ -353,6 +353,28 @@ Deprecated and Removed Features
CMake 3.1 again requires the quotes for this to work correctly.
+* Prior to CMake 3.1 the Makefile generators did not escape ``#``
+ correctly inside make variable assignments used in generated
+ makefiles, causing them to be treated as comments. This made
+ code like::
+
+ add_compile_options(-Wno-#pragma-messages)
+
+ not work in Makefile generators, but work in other generators.
+ Now it is escaped correctly, making the behavior consistent
+ across generators. However, some projects may have tried to
+ workaround the original bug with code like::
+
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-\\#pragma-messages")
+
+ This added the needed escape for Makefile generators but also
+ caused other generators to pass ``-Wno-\#pragma-messages`` to
+ the shell, which would work only in POSIX shells.
+ Unfortunately the escaping fix could not be made in a compatible
+ way so this platform- and generator-specific workaround no
+ longer works. Project code may test the :variable:`CMAKE_VERSION`
+ variable value to make the workaround version-specific too.
+
* Callbacks established by the :command:`variable_watch` command will no
longer receive the ``ALLOWED_UNKNOWN_READ_ACCESS`` access type when
the undocumented ``CMAKE_ALLOW_UNKNOWN_VARIABLE_READ_ACCESS`` variable is
-----------------------------------------------------------------------
Summary of changes:
Help/release/3.1.0.rst | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
hooks/post-receive
--
CMake
_______________________________________________
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits
