2010/8/31 Brad King <[email protected]>: > On 08/28/2010 10:51 AM, Eric Noulard wrote: >> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=013e0039eeb7e8bf213c3851161ce9a18f7b940d >> commit 013e0039eeb7e8bf213c3851161ce9a18f7b940d >> Author: Eric NOULARD <[email protected]> >> AuthorDate: Sat Aug 28 16:50:06 2010 +0200 >> Commit: Eric NOULARD <[email protected]> >> CommitDate: Sat Aug 28 16:50:06 2010 +0200 >> >> CPack handle symlinks in CPACK_INSTALLED_DIRECTORIES fix for bug5430 >> >> The proposed solution is to avoid to CopyIfDifferent any links >> found in CPACK_INSTALLED_DIRECTORIES but memorize them instead >> then at the end of the processing for each dir do re-create the >> link in the installed tree. >> Current patch should work if the link are "local" to the directory. > > This brings up another place for refactoring. It looks like the code > this patch modifies does the same thing that the file(COPY) and > file(INSTALL) commands do. In cmFileCommand.cxx there is a class > cmFileCopier and subclass cmFileInstaller used to implement those > commands. These could be factored out of this file and used in > CPack to install the directories into the package more robustly.
Wasn't aware of that class. I'll have a look and try to propose a new patch based on that class. I did reopen the bug. -- Erk Membre de l'April - « promouvoir et défendre le logiciel libre » - http://www.april.org _______________________________________________ cmake-developers mailing list [email protected] http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
