Thanks & done.

/Johan


On Tue, Feb 15, 2011 at 3:00 PM, Brad King <brad.k...@kitware.com> wrote:

> On 02/15/2011 08:39 AM, Johan Björk wrote:
> > Hi everyone,
> >
> > I created a patch which adds support for multiple folders in Xcode;
> >  http://www.vtk.org/Bug/view.php?id=10039
> >
> > I wasn't able to find a good place for common string helpers or similar,
> > in cmSourceGroupCommand.cxx, there is an inline copy of a tokenize()
> > function which I bluntly copied to cmGlobalXCodeGenerator.cxx in my
> > patch, but that's really ugly :(.
> >
> > Where should code like that go? In KWSys?
>
> Please factor it out into cmSystemTools.(h|cxx).
>
> Thanks,
> -Brad
>
_______________________________________________
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to