yep, but will need to update the code to print the attribute name using
PrintString(). Will send updated patch.


On Tue, Apr 5, 2011 at 3:23 PM, Brad King <[email protected]> wrote:

> On 04/05/2011 09:17 AM, Johan Björk wrote:
> > Tiny patch attached to support build-setting conditions in XCode
> > (XCODE_ATTRIBUTE_...[sdk=iphone]) for example. The issue was simply that
> > XCode requires the key to be quoted when it contains [].
>
> I think the right place for this is in cmXCodeObject::PrintString where
> it already checks for characters that need quoting.  Does that work?
>
> -Brad
>
>


-- 
Johan Björk
Team Lead, Development Tools
Spotify AB
Address: Birger Jarlsgatan 6, 114 46 Stockholm, Sweden
Phone:+46 (0)709 22 59 02

This e-mail (including any attachments) may contain information that is
confidential and/or privileged. It is intended only for the recipient(s).
If you have reason to believe that you are not the intended recipient of
this e-mail, please contact the sender immediately and delete the e-mail
from your computer.
_______________________________________________
cmake-developers mailing list
[email protected]
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to