On 9/26/2011 11:48 PM, Peter Collingbourne wrote:
Now that the Ninja generator is passing all tests on Linux, I have
decided to start preparing patches, and I am starting with some
refactorings and bug fixes developed in the course of developing the
Ninja generator.  Three of the patches were originally by Nicolas
Despres, the rest are by myself.

Fantastic!  Thanks for the well-formatted patch submission.  It was easy
to review the inline patch series.  I also fetched your prep branch from
github.  I think we can merge it as soon as the 2.8.6 release is finalized.

Patches 1-6 look good.  Please expand the commit message in patch 7 to
elaborate on the specific problems it fixes.  That looks like a real bug
fix rather than just refactoring.  I guess no one has been using per-config
link flags.

Thanks!
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to