Brad King wrote:

> On 10/6/2011 8:54 PM, Stephen Kelly wrote:
>> Well that didn't take long. I pushed a target-link-libraries-interfaces
>> branch to stage.
> 
> Good start.  Please change the three Doing*Interface modes into an
> enumeration so we don't have to worry about keeping three booleans
> in a consistent state.  

Done.

> Also, I think the documentation can be
> simplified for that signature:
> 
>   target_link_libraries(<target> <LINK_PUBLIC|LINK_PRIVATE> [libs...]
>                         [<LINK_PUBLIC|LINK_PRIVATE> [libs...]] ...)
> 

Done.

> Of course this will be easier to test once you get your new linking
> test working everywhere in the other topic.

Yes. Unfortunately I've had to comment out the useful unit tests there (the 
ones expecting failure) because they don't fail on so many platforms.

I'll investigate that particular with a new thread though anyway.

Thanks for the review.

Steve.


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to