The patch reads the registry using CPACK_PACKAGE_NAME. Please fix that to use CPACK_PACKAGE_INSTALL_REGISTRY_KEY instead.
Clint On Nov 12, 2011, at 1:01 PM, David Cole wrote: > The patch looks reasonable. > > Question about it: > > Does it prompt the user with a question if you use the "/S" silent > installer flag on the command line? (See my recent blog post about > using that flag to achieve silent install/uninstall-ers... : > http://www.kitware.com/blog/home/post/186 ) > > Since it must be explicitly enabled, and it's OFF by default, I don't > see any harm in taking the most recent patch from 9946. I'll put it on > the roadmap for 2.8.7, provided it doesn't give us any issues on our > dashboard builds after merging to 'next'. If it does, I'll reply here > again and ask you to help out patching it up. > > > Thanks, > David > > > On Sat, Nov 12, 2011 at 1:35 PM, Patrick Gansterer <[email protected]> wrote: >> Hi, >> >> can someone have a look at my patch at [1]? The version version is now about >> an year (!) old. >> Are there any plans to use Gerrit at [2] for CMake too, so there is a >> central place for all open patches? >> >> [1] http://public.kitware.com/Bug/view.php?id=9946 >> [2] http://review.source.kitware.com/ >> >> - Patrick >> -- >> >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the CMake FAQ at: >> http://www.cmake.org/Wiki/CMake_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers >> > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
