On Fri, Dec 2, 2011 at 7:54 AM, Stephen Kelly <steve...@gmail.com> wrote: > Brad King wrote: > >> On 11/29/2011 7:34 AM, Stephen Kelly wrote: >>> I worked on the functionality for per-config target includes, but the >>> syntax is not right yet. >> >> Please remove per-config support for now. > > Do you mean I should remove the UI feature of setting the > INCLUDE_DIRECTORIES_DEBUG property adding to the include directories of the > debug config, or do you additionally mean that I should remove the current > implementation that keeps order and keeps the specified config. > > The current implementation (std::vector<std::pair<std::string, std::string> >>) would work for the UI syntax you suggest below. It seems like removing > the implementation detail only for it to be re-added later when the UI > syntax is decided would be inefficient. > > I'm fine with removing the INCLUDE_DIRECTORIES_<config> UI feature. > >> With the approach I have in mind it will be a simple matter to add support >> for it after the main feature works. I want to make the approach >> something >> general so it can be applied to other things like link directories. The >> idea is to process the single list in the generator and look for special >> syntax that indicates whether each entry is meant for the current config. >> >> I haven't settled on a syntax yet but it will be similar to generator >> expressions from add_test and add_custom_command: >> >> $<CONFIG?Debug:/dir/for/Debug> >> >> This entry would be ignored if the CONFIG? condition doesn't match. The >> cmGeneratorExpression class can be used to evaluate it. > > Ok. Is this something that should aim for post-2.8.7? Should I aim to get > taget specific INCLUDE_DIRECTORIES into 2.8.7 (within this week) and aim for > adding this config-specific feature later (would that be source > compatible?). > > Thanks, > > Steve. > > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
I, for one, would really like to see per-target include directories in 2.8.7, even without per-config support to start with. Then, add the per-config support / new generator expressions in a later release. Thx, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
