On Tue, Nov 1, 2011 at 1:52 PM, Rolf Eike Beer <e...@sf-mail.de> wrote: > These two patches address some issues I found: > > -ExternalProject_Add(... DEPENDS something) does not work if that something is > not itself created by ExternalProject_Add(). Fixed and testcase added. > > -The testcases for ExternalProject fail to detect on my German system my > Subversion version. We had the issue back in the FindSubversion.cmake some > time again and fixed it there, no need to duplicate the old wrong code here. > > The patches are independent of each other. > > Greetings, > > Eike > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
I'm not convinced the DEPENDS patch makes things better... ExternalProject works best (and is easiest to think about) when it is used in a "SuperBuild" sort of scenario in which *all* the targets are ExternalProject targets. Encouraging users to mix EP targets and non-EP targets is a mistake, I think. While it is allowed and achievable to mix things, it is certainly not easy, and requires mucho understanding and thought. Besides, you can easily do an "add_dependencies" after adding an ExternalProject if it depends on something else in your build that is not an ExternalProject. I'm not dead set against the DEPENDS patch, but I don't see it as urgent. What do others here think? The subversion patch, though, looks pretty reasonable. I'll merge that and push to 'next' later today. Thanks, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
