2012/5/21 Brad King <brad.k...@kitware.com>: > On 05/21/2012 03:50 AM, Eric Noulard wrote: >> My merge of "stage/CPack-activateRPM-DEB-onMacOS" to next yesterday raised >> some warning on this dashboard: >> http://open.cdash.org/viewBuildError.php?type=1&buildid=2293803 >> >> the warning are right, the static method call *is always true* but >> shall I really try to avoid such warning? >> The always true may become "some day" not always true but I wanted to have >> CPackGeneratorFactory be coded in a uniform way. >> >> What shall I do with that? > > Try this: > > diff --git a/Source/CPack/cmCPackGeneratorFactory.cxx > b/Source/CPack/cmCPackGeneratorFactory.cxx > index dbfdbbc..37ff460 100644 > --- a/Source/CPack/cmCPackGeneratorFactory.cxx > +++ b/Source/CPack/cmCPackGeneratorFactory.cxx > @@ -40,6 +40,10 @@ > > #include "cmCPackLog.h" > > +#if defined(__BORLANDC__) > +# pragma warn -8008 /* condition is always true */ > +#endif > + > //---------------------------------------------------------------------- > cmCPackGeneratorFactory::cmCPackGeneratorFactory() > {
Ok just pushed that: Merge topic 'CPack-activateRPM-DEB-onMacOS' into next 801ea70 Calm down Borland compiler warning about "always true" >> Then the same set of commits may be responsible for that: >> http://open.cdash.org/buildSummary.php?buildid=2294180 >> >> but I can't find a reason for all 192 failing tests, can anyone enlight me? >> The only thing I see is >> >> "[flag] ArgumentExpansion Failed Passed 900ms Completed (SEGFAULT)" >> >> I cannot imagine why my change would generate such SEGFAULT series ... > > The same machine passed its nightly build so something local must have > gone wrong for the continuous. I don't think it's related to your change. ok then. Thanks Brad. -- Erk Le gouvernement représentatif n'est pas la démocratie -- http://www.le-message.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
