On 6/11/2012 10:21 PM, Peter Kümmel wrote:
All tests pass now for MSVC and MinGW!
With some small patches for ninja:
https://github.com/syntheticpp/ninja/commits/ninja-for-cmake
The changes are only needed for msvc when the build
dir path contains spaces, and for mingw because of slashes
in path names.
Great work. Nice to see. What are the chances of those changes being
accepted upstream? I am a bit concerned about the quote stuff.
Putting quotes in and then taking them out. Where do the quotes come
from? Is there another way to put paths with spaces into ninja? Most
of the tests except the depend stuff was passing with spaces in the path
before these changes. Is this all about the .d file contents?
-Bill
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
