The following issue is now in status NEW (again) ====================================================================== http://public.kitware.com/Bug/view.php?id=12951 ====================================================================== Reported By: Amine Khaldi Assigned To: ====================================================================== Project: CMake Issue ID: 12951 Category: CMake Reproducibility: always Severity: major Priority: normal Status: new Target Version: CMake 2.8.10 ====================================================================== Date Submitted: 2012-02-09 11:47 EST Last Modified: 2012-08-20 11:52 EDT ====================================================================== Summary: The DEFINE variable doesn't expand with VS generators but expands correctly with the nmake one Description: We (ReactOS) set CMAKE_ASM_COMPILE_OBJECT and use <FLAGS>, <DEFINES>, <OBJECT>...etc. The <DEFINES> expands like the rest of those variables when the nmake files generator is used, but doesn't expand when you use the VS generators. This is blocking us from using them because many of our core components contain asm files as source files. ======================================================================
---------------------------------------------------------------------- (0028546) Brad King (manager) - 2012-02-09 13:45 http://public.kitware.com/Bug/view.php?id=12951#c28546 ---------------------------------------------------------------------- Variables like CMAKE_ASM_COMPILE_OBJECT are used only by the Makefile generators. The VS generators just put the sources in the IDE project file and ask VS to build the project. The VS generators know how to put preprocessor definitions in place. However, assembly support is immature compared to C and C++ support in general. ---------------------------------------------------------------------- (0028547) Amine Khaldi (reporter) - 2012-02-09 13:57 http://public.kitware.com/Bug/view.php?id=12951#c28547 ---------------------------------------------------------------------- I see. Is it possible then to fix the VS generators so that a simple add_library(foo.c bar.s) could lead to having two objects linked instead of just the C one ? Right now the generated VS solution silently ignores all asm source files. As a result we're missing out on many nifty things that require VS projects. Thank you for the prompt reply. ---------------------------------------------------------------------- (0028549) Brad King (manager) - 2012-02-09 14:29 http://public.kitware.com/Bug/view.php?id=12951#c28549 ---------------------------------------------------------------------- I'm not sure the current state of VS support for assembly in our generators and I've not worked with assembly in the VS IDE projects myself. We've not had time/drive/need/resources to implement first-class assembly support in the VS generators. Assembly support has been a user-contributed and user-maintained feature for the most part so far. We are happy to review patches :) ---------------------------------------------------------------------- (0030364) David Cole (manager) - 2012-08-11 21:09 http://public.kitware.com/Bug/view.php?id=12951#c30364 ---------------------------------------------------------------------- Sending old, never assigned issues to the backlog. (The age of the bug, plus the fact that it's never been assigned to anyone means that nobody is actively working on it...) If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it: http://www.cmake.org/mailman/listinfo/cmake It's easy to re-activate a bug here if you can find a CMake developer who has the bandwidth to take it on, and ferry a fix through to our 'next' branch for dashboard testing. Issue History Date Modified Username Field Change ====================================================================== 2012-02-09 11:47 Amine Khaldi New Issue 2012-02-09 13:45 Brad King Note Added: 0028546 2012-02-09 13:57 Amine Khaldi Note Added: 0028547 2012-02-09 14:29 Brad King Note Added: 0028549 2012-08-11 21:09 David Cole Status new => backlog 2012-08-11 21:09 David Cole Note Added: 0030364 2012-08-20 11:52 David Cole Status backlog => new 2012-08-20 11:52 David Cole Target Version => CMake 2.8.10 ====================================================================== -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
