David Cole wrote: > Steve, we didn't take "generator-expression-target-properties" yet because > the logic is incorrect in this commit: > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4557c8db > > The test should be !IsGeneratorExpression, not 0!='$' && 1!='<' -- please > write a function there instead to make the logic more readable. And > consider adding a test of the case so that this would have been a test > failure for you rather than having Brad and I catch it during review.
You have to admit, that's quite an edge-case test :). Good catch. Added now to the branch. > > Also, you've added $<BOOL, $<STREQUAL, $<ANGLE-R and $<COMMA, but did not > add any tests of these expressions. We should really have tests of those > before we take this change into 'master'. Indeed. Tested and fixed now. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers