On 09/29/2012 05:47 AM, Nils Gladitz wrote:
> I've updated the patch (attached) to include a "TIMESTAMP" sub-command 
> for "file" as well (I hope indentation is also fixed).

Thanks.

Use of std::time_t and std::tm will not compile on all of CMake's platforms.
Other code already uses "#include <time.h>", "time_t", and "struct tm".

Also, IMO the result in the case of failure should be the empty string
rather than NOTFOUND.  The latter is a convention in the find_* commands
that should never have been used elsewhere.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to