05.10.2012 21:06, Brad King пишет: > On 10/05/2012 08:29 AM, Aleksey Avdeev wrote: >> I modified the proposed modules. > > Thanks for working on them. Let's start with FindIcotool since it > is pretty simple and doesn't depend on the other modules. After > that we can move on to the others. Please proceed with step 5 > of the new maintainer instructions: > > http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer > > to get Git access.
In the form of <https://www.kitware.com/Admin/SendPassword.cgi>, who is defined in the Reference (Name of someone who can verify that you deserve the access you're requesting)? > >>>> 1. FindIcotool >> http://git.altlinux.org/people/solo/public/cmake-modules.git?p=cmake-modules.git;a=blob;f=Modules/FindIcotool.cmake;h=97543113756a72e59175c778eace0dc00220a1e0;hb=ea809d0c5b1cd36b83437043d916fd6eacc1dc5f > > Good. Please tweak the documentation: > > (1) Remove the leading/first "#" line that is otherwise empty. Done. > (2) Remove the " (since CMake 2.8.8)" note since the module was > not in CMake 2.8.8. Done. > > Also when the module is put in CMake the line > > include(FindPackageHandleStandardArgs) > > will need to be > > include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake) Done. > >> Done. Value ICOTOOL_VERSION_STRING up over the output: >> >> icotool --version > > The output parsing can be a bit simpler if you use the CMAKE_MATCH_1 > variable result from the "if(... MATCHES ...)" command. It is > mentioned at the bottom of the regex documentation in string(): > > http://www.cmake.org/cmake/help/v2.8.9/cmake.html#command:string Yes, that is really better. Done. I ask to see the modified version: <http://git.altlinux.org/people/solo/public/cmake-modules.git?p=cmake-modules.git;a=commit;h=a1adf39598ff7e378cdec8eb31b23908df916b59>. -- Sincerely. Alex.
signature.asc
Description: OpenPGP digital signature
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers