Brad King wrote:

> On 11/01/2012 09:34 AM, Stephen Kelly wrote:
>> I've pushed a fix for the $<CONFIG> generator expression to do case
>> insensitive comparison, as it was in CMake 2.8.9
>> (generator-expression-bug- fixes). I haven't yet merged to next as I
>> would like to add a test.
> 
> This looks like a regression in 2.8.10.  When was it discovered?
> This should have been fixed during the RC cycle.

Yes, unfortunately I just discovered it today while working on generator 
expressions for linking.

> 
>> Is there any existing comparable tests in CMake that I could copy the
>> pattern of?
> 
> Nothing jumps to mind off the top of my head.  It should probably be
> one of the Tests/RunCMake style tests.  See if you can add it to the
> Tests/RunCMake/GeneratorExpression block of tests.

Yes, I looked into that, but I'm not sure how to actually do it.

RunCMake.cmake seems to use:

  execute_process(
    COMMAND ${CMAKE_COMMAND} "${RunCMake_TEST_SOURCE_DIR}"
              -G "${RunCMake_GENERATOR}" -DRunCMake_TEST=${test}

I'm not sure if I should just add API for a -
DCMAKE_BUILD_TYPE=${RunCMake_BUILD_TYPE} there and just limit the test for 
this to the makefile generators?

Thanks,

Steve.


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to