Cleaned up the commits See the new branch here: https://github.com/hiwrac/CMake/commits/static_linker_flags_clean
CMAKE_STATIC_LINKER_FLAGS is now optional on all generators. XCode is supported properly. On Tue, Dec 11, 2012 at 8:44 AM, Brad King <[email protected]> wrote: > On 12/10/2012 05:45 PM, Evan Pipho wrote: > > I am nearly finished with this, just need to write the variable > documentation and test the xcode generators. > > Thanks for working on this. > > > I have committed everything so far to my github fork at > > https://github.com/hiwrac/CMake/commits/static_linker_flags > > We can fetch your topic from there so there is no need for a > separate submission. > > I just took a quick look. Here are some comments. > > (1) Please arrange your commits to do cleanup and rearrangement > changes first, and then real changes in separate commits. > Currently both are mixed together so it is hard to see what > happened to existing functionality (like target properties). > > (2) GetRequiredDefinition is too strict for this. We do not > actually need to have a definition of these variables to > produce a valid build system. Use plain GetDefinition > and simply skip the feature if it returns NULL. > > Please rewrite your topic to address these and then post back > here so we can take another look. > > Thanks! > -Brad >
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
