Brad King wrote: >> I'd like to focus first on the on those commits and get them ready for >> review. They are in the interface-includes-defines branch in my clone. > > Here are some comments: > > * Please add a test for the TARGET_NAME non-literal error cases, both in > direct use of the expression and in export generation.
Done. > * In the "Use mapped config properties to evaluate $<CONFIG>" you add code > to handle MAP_IMPORTED_CONFIG. I think that should be an API on > cmTarget refactored from its existing imported config selection code. You mean you want the $<CONFIG:mappedCfg> expression to depend on whether LOCATION_mappedCfg exists, as the logic in ComputeImportInfo requires? >> I was wondering when the release-candidate period will start for 2.8.11? >> Or will there be a release-candidate period at all anymore? Is the 2.8.11 >> release scheduled? > > There will be a RC period but we haven't scheduled it yet. Ok. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
