Alexander Neundorf wrote:

> On Friday 25 January 2013, Brad King wrote:
>> On 01/25/2013 03:24 PM, Alexander Neundorf wrote:
>> > On Friday 25 January 2013, Brad King wrote:
>> >> On 01/25/2013 05:14 AM, Stephen Kelly wrote:
>> >>> Are INSTALL(EXPORT)ed files affected at all by this? Do they need to
>> >>> be?
>> >> 
>> >> Yes, since they compute paths relative to their location in order
>> >> to be relocatable.  The code that generates them may need to be
>> >> made aware of this.
>> > 
>> > I don't think so.
>> > These file should be installed into lib/, so even if lib/ is a symlink,
>> > the relative path from the targets file to the library does not cross
>> > the symlink.
>> 
>> What if an executable target installed to bin/ is exported in the targets
>> file?
> 
> Right.

It looks like you merged your patch to next, but didn't account for this 
part. I recommend doing something similar to what you did for the macro to 
manipulate the _IMPORT_PREFIX in export files. Wait for my fix-relocatable-
include-dirs topic to be merged first though.

Thanks,

Steve.



--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to