On 05/23/2013 06:58 AM, Stephen Kelly wrote: > I settled on PRESET_VISIBILITY because it does not have the word default in > it, which avoids. I don't want to bikeshed the name, so if you chose > something you'd prefer, I don't mind changing it.
I like "PRESET" but I prefer "VISIBILITY_PRESET" because we could perhaps have other "VISIBILITY_*" properties later. >>> In my understanding of your proposal, VISIBILITY_DEFAULT == "hidden" >>> will add -fvisibility=hidden *and* -fvisibility-inlines-hidden. >>> Should we have a way to skip the latter e.g. "hidden-no-inlines"? >> >> Perhaps. If we can figure out how to name everything. > > I decided to use a separate option. Perhaps the property "VISIBILITY_INLINES_HIDDEN"? -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
