On 06/27/2013 03:35 AM, Stephen Kelly wrote: > Brad King wrote: >> On 6/26/2013 12:24 PM, Stephen Kelly wrote: >> I think the generated targets file will need to bump its >> minimum required version of CMake if the policy is NEW >> and the compatibility export option is not used. Otherwise >> consuming projects running older CMake versions will silently >> get through the CMake step and fail at build time. > > Yes, something has to be done to fix that. I would add a check on the cmake > version with a FATAL_ERROR, like in the Qt 5 config files. It looks like > bumping the CMAKE_IMPORT_FILE_VERSION alone wouldn't have any effect because > there is no other code checking it, so that would have to be added. It seems > easier to me and no worse to add a FATAL_ERROR?
Yes, a version check with a fatal error would work. The CMAKE_IMPORT_FILE_VERSION is for forward compatibility. I do not know if we'll ever use it but I wanted to add it at the beginning just in case. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
