Nicolas Desprès wrote:
>> + UpdateOutputToSourceMap(outputs, file);
>>
>> is missing a 'this->', as per the style. There's a couple of repeats of
>> that.
>>
> Done
You seem to have missed this one.
There are also other style issues.
* Don't put an else after a return
* Wrap single line blocks in {}
> That's said we can optimize further as I mentioned in my comment (
>
https://github.com/nicolasdespres/CMake/commit/59c871da8b00554812e93ba9c6e47d864424efb0#L0R2023).
> Do you have an opinion about it?
Do I understand correctly that the issue is that OutputToSource values can
be absolute or relative paths? That would be fixable by patching only
UpdateOutputToSourceMap, right?
Thanks,
Steve.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
