Alexander Neundorf wrote: > On Friday 19 July 2013, Rolf Eike Beer wrote:
> > Ok, I've pushed an updated version to the rework branch. A test for the > > component check is missing, but all of your other suggestions should have > > been addressed. > > The variable is case-sensitive, so it is CXXFeatures_FIND_COMPONENTS, not > CXXFEATURES_FIND_COMPONENTS. Fixed. > I'm not sure I would have made this a find-module, instead of a simple > module which can be included and then provides a function, but I think this > doesn't matter much. Because I get things like components for free then ;) > And of course, before merging into cmake, the cmake_minimum_required() call > can be removed. Yes, and some other minor things. I have a list somewhere, probably on my other machine. Eike --
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
