On 08/14/2013 01:02 PM, David Cole wrote: > We should (maybe I will if I get time to spend on it) write a test that > executes something like this command: > > $ git grep -E "[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9].*cmPolicies" > Source/cmPolicies.cxx: 2,8,11,20130516, cmPolicies::WARN); > Source/cmPolicies.cxx: 2,8,11,20130516, cmPolicies::WARN); > Source/cmPolicies.cxx: 2,8,11,20130724, cmPolicies::WARN); > > And make sure the results are empty-ish... Then if somebody does this > later on, it will be a test failure.
Robert and I are adding a check like git grep 2.8.11.20.. to the release process to look for cases that need a version comparison update (where 2.8.11 is the existing release). That will catch Source/cmPolicies.cxx lines too. If you can add a test to catch the cmPolicies entries earlier that would be even better. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers