Hello Bill,
thanks for checking up on the changes!
On 21.10.2013 19:04, Bill Hoffman wrote:
Can you add a few comments into the code that describe what you are
doing so it will be easier to follow? Maybe a block comment that
describes the high level approach?
I've added comments to the code blocks in CreateTestCostList().
// This should work:
if(this->Tests[test].size() == 0)
Changed.
It would also be good to merge your test case
http://pastebin.com/3zXsTrem into its own test or one of these:
CTestTestParallel.
I am not yet entirely sure how to do that since the test case (and the
underlying behavior in vanilla cmake) is sporadic and still needs some
machine detectable failure condition but I'll try looking into it.
I am also getting a test failure here:
190: Test project C:/Users/hoffman/Work/My
Builds/cmake-ninja/Tests/CTestTestStopTime
190: Start 1: TestSleep
190: 1/2 Test #1: TestSleep ........................ Passed 29.99 sec
190: Start 2: ShouldNotRun
190: 2/2 Test #2: ShouldNotRun .....................***Failed 30.00 sec
190:
190: 50% tests passed, 1 tests failed out of 2
190:
190: Total Test time (real) = 60.00 sec
190:
190: The following tests FAILED:
190: 2 - ShouldNotRun (Failed)
1/1 Test #190: CTestTestStopTime ................***Failed Required
regular expression not found.Regex=[The stop time has been passed
] 60.67 sec
I haven't see that fail on my local test runs.
Is it sporadic or does it fail for you consistently?
Nils
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
