Alexander Neundorf wrote: > On Thursday 24 October 2013, Stephen Kelly wrote: >> Hi, >> >> I've pushed the Qt-auto-generators topic to stage. This topic was >> discussed here: >> >> http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/7936 >> >> I have tested it with ports of KDE Frameworks and GammaRay to use the >> features. >> >> Alex, could you also review the topic please? > > Looks good in general. > Just some nitpicking: this is still Qt-specific, so I would prefer to have > something related to Qt in the names of the target properties and output > and maybe also if the generated files instead of AUTOGEN_TARGETS_FOLDER, > "AUTOGEN:" and and AutogenInfo.cmake.
I thought about that but couldn't think of better, more suitable names. Also, just because it's Qt-specific now doesn't mean it always will be. If there's a reason for something similar relating to another tool, another rename would be needed. I'd prefer to stick with Autogen*. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
