This separator:

+#   #--Extract step --------------

should not be there because EXTRACT_COMMAND is actually an option
of the download step.  There is no separate timestamp-managed
extraction step.

In fact, *all* the other *_COMMAND parameters to ExternalProject_Add yield a time-stamp managed "step".... If the name of this parameter is EXTRACT_COMMAND, then I would strongly suggest conforming to the existing pattern, and making "extract" be a full-fledged separate step.

If you don't think that's appropriate, then I would suggest using a different name than EXTRACT_COMMAND.

I think it's good to maintain as much consistency as possible. Especially given the sheer number of possible parameters to ExternalProject_Add.


David C.

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to