Ok, I’ve pushed the new changes. 8) One of the reasons I didn't add LINK_OPTIONS before was that I didn't know whether it should accept "--no-undefined" or "-Wl,--no-undefined", or both. Is the latter compiler-driver-specific? Is that irrelevant because the link option is tool specific anyway?
Forgot to answer this question. I think that that diff between —no-undefined/-Wl,—no-undefined is mostly irrelevant because the option is tool specific. What is less clear is how to go about changing the default tool for the linker. On Feb 4, 2014, at 9:39 AM, Steve Wilson <ste...@wolfram.com> wrote: > > On Feb 4, 2014, at 3:49 AM, Stephen Kelly <steve...@gmail.com> wrote: > >> Stephen Kelly wrote: >> >>> 7) I've added two commits to your branch. Please squash them into the >>> appropriate commits in your topic. >>> > > My bad, missed that one. > >> Oh, forgot this one: >> >> 8) I get some unit test failures: >> >> The following tests FAILED: >> 85 - LinkFlags-dll_config (Failed) >> 87 - LinkFlags-exe_config (Failed) > > Working on this failure now. > > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
signature.asc
Description: Message signed with OpenPGP using GPGMail
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
