On 03/14/2014 09:38 AM, Jiri Malak wrote: >>> I enclosed patch to fix COMPILER_VERSION variable value >>> for Open Watcom compilers to be real version, not internal number. >> [snip] >>> + /* __WATCOMC__ = VVRR + 1100 Open Watcom */ >> >> What do you think about changing the compiler id to "OpenWatcom"? >> > It can be changed, I am using Watcom as simple word.
My concern is that we've reported CMAKE_C_COMPILER_ID as "Watcom" along with CMAKE_C_COMPILER_VERSION holding numbers like 12.x for a long time. Projects may have logic that switches off these version values when they see the id is "Watcom". By changing to "OpenWatcom" we get a more accurate description of the compiler name and can restart the version sequence at 1.x. Please fold this into the patch. Also please split the patch into two commits. The first should do the compiler id and version change, and the second should do the platform and architecture fix. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
