On Fri, Apr 18, 2014 at 10:06:36 -0400, Matthew Woehlke wrote:
> Where a variable is created (e.g. the SET command), presumably.

Internally-created variables would then be missed.

    string(TOUPPER "mystr" "varname with spaces")

> I don't think the performance hit should be so bad if only writes are
> checked, should it?

Actually, I stuck a bloom filter in front of the definition map check to
get a decent performance improvement (10%-20% depending on the project)
on another branch. Using the loop which hashes to also check for valid
characters might be possible.

--Ben
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to