... Long story short I think it is safe to assume ...


It is never safe to assume anything. I don't have personal experience with protobuf....

But in general, inputs to CMake are allowed to be full path or not, and when not, they're usually treated relative to CMAKE_CURRENT_SOURCE_DIR. Consult the documentation on individual functions for details. After this, I'll be quiet on this, but I wouldn't accept the patch as is without a guarantee that relative paths are the only ones allowed as input.

Hopefully, Philip Lowman is listening, and he can chime in. He's listed as the FindProtobuf module maintainer here: http://www.cmake.org/Wiki/CMake:Module_Maintainers


Cheers,
David C.

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to