On 06/06/2014 04:16 AM, Tim Blechmann wrote: > i've came across, that .rc files are treated as windows resources, but > not upper-case .RC files. attached patch tries to correct this. it is a > functional change, though it brings the implementation in line with > Modules/CMakeCXXCompiler.cmake.in and the like. > > would be great if someone could review and/or commit it.
The cmSystemTools::GetFileFormat is supposed to have been replaced by cmSourceFile::GetLanguage and cmGeneratorTarget source classification logic that uses the tables like that in CMakeCXXCompiler. The only cmSystemTools::GetFileFormat call site I see left is in cmQtAutoGenerators::SetupSourceFiles, and that does not care about RESOURCE_FILE_FORMAT. In what context does your patch affect anything? Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
