On 06/13/2014 05:19 AM, Stephen Kelly wrote: > However, that would mean requiring the user to install multiple files rather > than just one. So, it might make sense to add a new signature > > write_compiler_detection_header( > DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/compiler_detection"
Installing directories can lead to leftover cruft in incremental builds. The caller should pass in a variable to receive the list of files to be installed. > 11) WriteCompilerDetectionHeader vs GenerateExportHeader IMO these two modules are solving orthogonal problems and should not be mixed. > 12) Platform-specific defines Plenty of libraries already provide things like this. Not everyone agrees what "UNIX" or even "Linux" means. I was hesitant to accept WriteCompilerDetectionHeader in the first place because I never wanted to get in the business of providing a C++ SDK. It is reasonable to re-use all the C++ compiler version and feature info we already have, but I don't think we should provide more. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers