On 07/29/2014 03:31 AM, Nils Gladitz wrote:
> While looking for places to add my new CMAKE_${lang}_LINKER_SUPPORTS_PDB 
> I found the following in Windows-df.cmake:
> 
> set(CMAKE_${lang}_COMPILER_LINKER_OPTION_FLAG_EXECUTABLE "/link")
> 
> It looks suspicious because I don't think "lang" is actually set in that 
> context.
> 
> The only mention of "LINKER_OPTION_FLAG" seems to be 
> Source/cmNinjaNormalTargetGenerator.cxx

Running "git log -p -S_COMPILER_LINKER_OPTION_FLAG_" one can see
how that was added to help with Ninja+MSVC and then refactored
away later.  Please drop both locations.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to