I was trying to avoid the code duplication but I definitely see your
point.  I'll refactor.

- Chuck


On Wed, Aug 20, 2014 at 8:55 AM, Brad King <brad.k...@kitware.com> wrote:

> On 08/19/2014 05:43 PM, Chuck Atkins wrote:
> > The new hybrid mode allows the default search location to be
> > re-rooted and any user specified paths to be untouched.
>
> This looks useful.  However, the current implementation appears
> to change the order in which each kind of path is generated.
> The order is very important and cannot be changed.
>
> Instead you'll have to refactor the path generation to store
> a boolean with each value that indicates whether it is to be
> re-rooted or not.  Or, re-arrange the generation to construct
> separate lists of paths from each source first, and then
> combine them while re-rooting some.
>
> Thanks,
> -Brad
>
> --
>
> Powered by www.kitware.com
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Kitware offers various services to support the CMake community. For more
> information on each offering, please visit:
>
> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/cmake-developers
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to