On 09/18/2014 04:05 PM, Brad King wrote:
On 09/17/2014 02:25 PM, Nils Gladitz wrote:
I pushed "root-modules-set-policies-new" to stage which sets all
policies to NEW for modules from cmake's own Modules directory if
NO_POLICY_SCOPE is not used.
A minor comment on the impl: use cmSystemTools::GetCMakeRoot
instead of looking up CMAKE_ROOT.
Thanks, I'll try to remember that for next time.
I copied the use of CMAKE_ROOT from cmMakefile::GetModulesFile().
However, I do not think this approach will work well in general.
We do not have extensive testing covering all functionality of
the builtin modules. We do not actually know that all the
modules will work with every policy set to NEW right away.
Typically authors of projects that use the modules will report
bugs if things break when the projects set policies to NEW.
Meanwhile at least existing projects keep building with the
OLD policy behavior.
OK, thanks.
I unstaged the topic.
Nils
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers