Your revision looks better ;) I even would prefer to not hardcode the SDK but I was unable to list key entries from the registry.
Usually all installed SDKs are listed as subkeys of HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows CE Tools\\SDKs in this case it is SDK_AM335X_SK_WEC2013_V310. I think the test would be nicer if it checks for available SDKs and just picks the first. Any ideas how to do this? Regards Pascal > -----Original Message----- > From: Brad King [mailto:brad.k...@kitware.com] > Sent: Dienstag, 21. Oktober 2014 14:58 > To: Bach, Pascal; cmake-developers@cmake.org > Subject: Re: [cmake-developers] [PATCH] WINCE: Run Tutorial steps 1-4 as > tests for Windows CE > > On 10/21/2014 05:24 AM, Pascal Bach wrote: > > --- > > Tests/CMakeLists.txt | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > The Wow6432Node path component should not be needed because > CMake is aware of how to lookup different registry views. > Also we can fold the lookup into existing infrastructure > a few lines above. > > Please try the attached revision to your patch. > > Thanks, > -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
