On Fri, Oct 24, 2014 at 10:54:17 -0400, Ben Boeckel wrote: > On Fri, Oct 24, 2014 at 15:24:57 +0100, Alex Merry wrote: > > On Friday 24 October 2014 10:20:42 Brad King wrote: > > > On 10/24/2014 10:02 AM, Brad King wrote: > > > > commit 5abfde6cb8a1ae0b2825797eab6c2e9842eb7c49 > > > > Author: Ben Boeckel <ben.boec...@kitware.com> > > > > Date: Wed Mar 12 14:01:45 2014 -0400 > > > > > > > > cmDefinitions: Don't store parent lookups > > > > > > > > When looking up scopes, it is faster to not store the lookup locally > > > > to > > > > keep the maps smaller and avoid extra allocations and rebalancing. > > So the problem was that when redoing the "pull" logic for PARENT_SCOPE, > it was unconditional when it should be skipped if the variable is > already local.
So after discussion with Brad, this commit breaks other subtle behaviors as well, so the plan is to just revert it instead and defer its optimizations until after 3.1 once proper tests are in place (more under development now). --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
