Merged: c752f8f165e9b8db7bc645cc55301277cd7773be Merge topic 'find-boost-no-reroot'
- Chuck On Sun, Oct 26, 2014 at 12:18 AM, Chuck Atkins <[email protected]> wrote: > Guillaume, > > Nice patch! Good detail in the commit message. I make a few minor tweaks > for typos and tense, but other than that, it's good. Pushed to stage as > 'find-boost-no-reroot' and merged to next for testing. We'll keep an eye > on the dashboards and fix as needed but I don't anticipate any issues. > > Thanks for the patch! > - Chuck > > On Thu, Oct 23, 2014 at 4:09 AM, Guillaume Papin < > [email protected]> wrote: > >> Please find the patch attached to this email. >> Let me know if anything is wrong. >> >> Best, >> Guillaume >> >> >> On 10/16/2014 05:09 PM, Chuck Atkins wrote: >> >> Guillaume, >> >> Please see CONTRIBUTING.rst in the top level of the CMake source tree. >> If you can please create and post a patch against cmake master then I'll >> work on getting it merged into cmake next. Thanks for the bug fix! >> >> - Chuck >> >> On Thu, Oct 16, 2014 at 10:32 AM, Chuck Atkins <[email protected]> >> wrote: >> >>> This looks like a reasonable way to accomplish this right now. The >>> underlying prioblem is that ther's no way to specify which path types get >>> re-rooted and which don't. Ideally you'd want to be able to specify in the >>> toolchain for something like this that all paths operate in "ONLY" mode >>> except HINTS, which you would want to place in NEVER mode. I'm currently >>> working on just such a feature but in the meantime, forcing it like this in >>> the FindBoost module looks reasonable. >>> >>> >> >> >
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
