Brad, I made the changes that you suggested wrt removing trailing whitespace and removing variables from the cache. I also reverted a recent change by replacing GSL_CONFIG_EXECUTABLE with GSL_CONFIG to remain consistent with the naming conventions of PkgConfig.cmake. The updated FindGSL.cmake is attached.
I also created a simple test for the new module (see attached FindGSL.tgz). If
ENABLE_FINDGSL_TEST is true, this test will be included. I am setting up a
nightly cmake regression on one of my machines that will run this test. In
addition to the new files found in FindGSL.tgz, the Tests/CMakeLists.txt will
require this simple addition:
--- a/Tests/CMakeLists.txt
+++ b/Tests/CMakeLists.txt
@@ -1252,6 +1252,11 @@ ${CMake_BINARY_DIR}/bin/cmake -DDIR=dev -P
${CMake_SOURCE_DIR}/Utilities/Release
add_subdirectory(FindGTK2)
endif()
+ find_package(GSL QUIET)
+ if(GSL_FOUND AND ENABLE_FINDGSL_TEST)
+ add_subdirectory(FindGSL)
+ endif()
+
add_test(ExternalProject ${CMAKE_CTEST_COMMAND}
--build-and-test
"${CMake_SOURCE_DIR}/Tests/ExternalProject"
I can build build and test cmake with my new tests in my local sandbox so I
have some confidence that the test is working as intended. I don't know how to
check the testing code in the cmake regression system w/o it being checked into
git.
Let me know how I should proceed.
-kt
FindGSL.cmake
Description: FindGSL.cmake
FindGSL.tgz
Description: FindGSL.tgz
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
